-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 allow non-provider Deployments in Tilt #9404
Conversation
@@ -382,7 +382,7 @@ def enable_provider(name, debug): | |||
|
|||
def find_object_name(objs, kind): | |||
for o in objs: | |||
if o["kind"] == kind: | |||
if o["kind"] == kind and "cluster.x-k8s.io/provider" in o["metadata"]["labels"]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ensures the provider's *_controller
item in tilt refers to the right Deployment.
What use case are we solving here? |
/hold |
CAPZ now includes Azure Service Operator in its manifests, so those components are not "additional" in the sense that they're already included and we don't have raw YAML representing those components since we feed them through kustomize. I expect any other provider that might also install another Deployment in the future would run into these same issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nojnhuh sorry for getting late to this, I'm ok with the change but please add some comment so we keep track of why we are doing this
@fabriziopandini Thanks! Just pushed those changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 2e1d80a8f62628629c9938771c754c7dfb8b5176
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What this PR does / why we need it:
This PR updates the Tilt dev setup to still install, but otherwise ignore, Deployment resources without a
cluster.x-k8s.io/provider
that come with a provider. CAPI may overwrite thecommand
for the container in a way that isn't compatible with the image, for example if the image doesn't containsh
, such that the container fails to start.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
/area devtools